fix: incorrect window shadow height for osd #1081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust shadowOffset by UI designer to avoid shadow height is not enough. pms: BUG-310841
18202781743
requested review from
BLumia,
fly602,
mhduiy,
robertkill and
yixinshark
deepin pr auto review关键摘要:
是否建议立即修改:
|
Reviewer's Guide by SourceryThis pull request adjusts the shadow offset and color of the OSD window to ensure the shadow height is visually correct, according to UI designer specifications. The shadow color is now theme-dependent, using a darker shade for the dark theme and a lighter shade for the light theme. The shadow offset was also modified. Updated class diagram for Window in main.qmlclassDiagram
class Window {
D.DWindow.windowRadius: int
D.DWindow.enableBlurWindow: bool
D.DWindow.enabled: bool
+D.DWindow.shadowOffset: Qt.point
+D.DWindow.shadowColor: Qt.rgba
color: string
DLayerShellWindow.bottomMargin: int
DLayerShellWindow.layer: DLayerShellWindow.LayerOverlay
}
note for Window "Adjusted shadowOffset and shadowColor properties for better visual appearance."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @18202781743 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider making the shadow offset configurable to avoid hardcoding the value.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
mhduiy
approved these changes
Apr 7, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust shadowOffset by UI designer to avoid shadow height is
not enough.
pms: BUG-310841
Summary by Sourcery
Bug Fixes: